Skip to content

Conversation

sakumisu
Copy link
Contributor

No description provided.

@sakumisu sakumisu marked this pull request as draft September 16, 2025 13:42
@Rbb666 Rbb666 requested a review from Copilot September 19, 2025 13:08
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds CherryECAT, a lightweight EtherCAT master stack designed for MCUs running with RTOS, to the package system. The addition includes both package metadata and configuration support.

  • Adds package definition with metadata, repository information, and licensing details
  • Introduces Kconfig configuration options for package integration and version selection

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
system/CherryECAT/package.json Defines package metadata, repository URL, and version configuration
system/CherryECAT/Kconfig Provides configuration menu and version selection options

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

},
"license": "Apache-2.0",
"repository": "https://github.com/cherry-embedded/CherryECAT",
"icon": "unknown",
Copy link

Copilot AI Sep 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The icon field is set to 'unknown'. Consider providing an appropriate icon for better package identification and user experience.

Suggested change
"icon": "unknown",
"icon": "https://github.com/cherry-embedded/CherryECAT/raw/master/logo.png",

Copilot uses AI. Check for mistakes.

"repository": "https://github.com/cherry-embedded/CherryECAT",
"icon": "unknown",
"homepage": "https://github.com/cherry-embedded/CherryECAT#readme",
"doc": "unknown",
Copy link

Copilot AI Sep 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The doc field is set to 'unknown'. Consider providing a link to proper documentation or setting this to a valid documentation URL for better user guidance.

Suggested change
"doc": "unknown",
"doc": "https://github.com/cherry-embedded/CherryECAT#readme",

Copilot uses AI. Check for mistakes.

@sakumisu sakumisu force-pushed the master branch 2 times, most recently from 9398465 to 7be5035 Compare October 11, 2025 13:41
Signed-off-by: sakumisu <[email protected]>
@sakumisu sakumisu marked this pull request as ready for review October 11, 2025 14:00
@Rbb666 Rbb666 merged commit 872ad0b into RT-Thread:master Oct 12, 2025
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants